executables: Allow any vars in enabled_if for executables#14860
executables: Allow any vars in enabled_if for executables#14860punchagan wants to merge 1 commit into
Conversation
|
This PR is stacked on top of #14848 |
punchagan
force-pushed
the
fix-14789
branch
2 times, most recently
from
23f275c to
6bac50b
Compare
Alizter
left a comment
Alizter
left a comment
There was a problem hiding this comment.
This mostly looks good. Of course, with allowing any variable to appear in enabled_if the impact of the change is quite wide as we would be allowing the user to write more nonsense if we are not careful. I need to go through the variables that we have and think a little in case any of them don't make sense.
We allow any vars in enabled_if within the library stanza, but only common_vars within the executable stanza. This commit fixes that and allows any vars within the executable stanza too. The dune lang version would need to be bumped for this to work, though. Signed-off-by: Puneeth Chaganti <punchagan@muse-amuse.in>
|
@punchagan can you scan the code base for other places where we limit the variables in this way? If we're going to lift this restriction, it's best to do it everywhere all at once rather than drip feeding it by stanza. @Alizter Not sure what you mean by writing nonsense. If a variable cannot be substituted, then either the cycle checker will complain or we will have no value to substitute for it. |
3 participants
We allow any vars in enabled_if within the library stanza, but only
common_vars within the executable stanza. This commit fixes that and
allows any vars within the executable stanza too.
Closes #14789