test(lib): share private only-packages fixture#14932
Open
rgrinberg wants to merge 1 commit into
Open
Conversation
rgrinberg
force-pushed
the
push-pxlqwtywuput
branch
3 times, most recently
from
0d89757 to
4e58980
Compare
Alizter
approved these changes
Jun 3, 2026
Collaborator
Alizter
left a comment
Alizter
left a comment
There was a problem hiding this comment.
Clean refactor: parameterizes the shared two-package private-only-packages setup by the macro under test and an optional lib1 extra field. cwd-leaving behaviour preserved.
rgrinberg
force-pushed
the
push-pxlqwtywuput
branch
3 times, most recently
from
adb3593 to
733663a
Compare
Extract the repeated two-package project used by lib-private and libexec-private --only-packages tests into a shared helper parameterized by the macro under test and optional lib1 fields. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-pxlqwtywuput
branch
from
733663a to
f30a9d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract the repeated two-package project used by lib-private and
libexec-private --only-packages tests into a shared helper parameterized by the
macro under test and optional lib1 fields.