Skip to content

test(cache): share copy rule project fixture#14939

Open
rgrinberg wants to merge 1 commit into
ocaml:mainfrom
rgrinberg:push-qlmtrppztrum
Open

test(cache): share copy rule project fixture#14939
rgrinberg wants to merge 1 commit into
ocaml:mainfrom
rgrinberg:push-qlmtrppztrum

Conversation

@rgrinberg
Copy link
Copy Markdown
Member

Extract the repeated Dune cache test project with a copy rule and source file
into a shared blackbox-test helper.

@rgrinberg rgrinberg force-pushed the push-qlmtrppztrum branch 3 times, most recently from e3ec9c0 to dea76f6 Compare June 3, 2026 12:51
@Alizter
Copy link
Copy Markdown
Collaborator

Alizter commented Jun 3, 2026

Stray unrelated change in write_cross_compilation_repro_project at line 576: the escaped \" inside the heredoc got unescaped, turning the dune snippet into (echo "let () = Format.printf "let x = 1"") — that's a broken sexp (the inner quote terminates the string). I think this is unintentional; could you drop that hunk?

Comment thread test/blackbox-tests/setup-script.sh Outdated
(with-stdout-to
gen.ml
(echo "let () = Format.printf \"let x = 1\"")))
(echo "let () = Format.printf "let x = 1"")))
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(echo "let () = Format.printf "let x = 1"")))
(echo "let () = Format.printf \"let x = 1\"")))

@rgrinberg rgrinberg force-pushed the push-qlmtrppztrum branch 3 times, most recently from a3b80e2 to 43b8ac1 Compare June 3, 2026 21:59
Extract the repeated Dune cache test project with a copy rule and source file
into a shared blackbox-test helper.

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
@rgrinberg rgrinberg force-pushed the push-qlmtrppztrum branch from 43b8ac1 to 48a8169 Compare June 3, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants