fix: rebuild consumers after private module interface changes - #16204
Draft
Alizter wants to merge 2 commits into
Draft
fix: rebuild consumers after private module interface changes#16204Alizter wants to merge 2 commits into
Alizter wants to merge 2 commits into
Conversation
Alizter
force-pushed
the
push-rvnyvqnxrump
branch
from
August 25, 2026 14:14
94f3023 to
1a4c702
Compare
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
push-rvnyvqnxrump
branch
from
August 25, 2026 14:20
1a4c702 to
be25f20
Compare
Replace hidden CMI directory globs with exact dependencies derived from the library module set. This preserves private-interface invalidation without eagerly building unrelated public or virtual-library wrapper CMIs. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
push-rvnyvqnxrump
branch
from
August 25, 2026 17:55
a448897 to
a5365ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Track both public and hidden CMI directories in library compilation dependencies. This ensures that changing a private module interface invalidates consumers which read it through a public module alias, instead of leaving stale artifacts that fail during linking.
The regression test added in #16174 now succeeds.
Related Issue and Motivation
Fixes #16071.