fix(engine): release process resources when spawning fails - #16266
Open
rgrinberg wants to merge 1 commit into
Open
fix(engine): release process resources when spawning fails#16266rgrinberg wants to merge 1 commit into
rgrinberg wants to merge 1 commit into
Conversation
Close prepared output descriptors and remove capture and response files when process spawning raises after allocating them. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-yvsvvmmqkwts
branch
from
August 30, 2026 12:30
45d6d27 to
8bfc74e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Process spawning allocated output captures before opening descriptors and
calling
Spawn.spawn, but released them only after spawning succeeded. Anexception therefore left captures and descriptors owned by a persistent Dune
process.
Release prepared outputs on both paths and remove captures and any response
file on failure. The regression from #16259 now observes an empty temporary
directory while Dune remains running.