fix(rpc): rebase forwarded paths to the workspace root - #16267
Open
rgrinberg wants to merge 1 commit into
Open
Conversation
Rebase build targets and runtest paths from the client's directory to the workspace root before sending them. Interpret those requests from the root on the server so its startup directory cannot affect their meaning. Apply the same client-directory prefix when exec chooses its context build directory. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-lytnrzpwrkyp
branch
from
August 30, 2026 12:33
0ef019d to
3dcc672
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relative build, runtest, and exec paths forwarded to a running Dune process were interpreted from the server's startup directory. Rebase them from the client invocation to the workspace root before sending, and interpret them from that root on the server.