Skip to content

Conversation

@voodoos
Copy link
Collaborator

@voodoos voodoos commented Dec 2, 2024

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4637

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 22.136%

Totals Coverage Status
Change from base Build 4636: 0.0%
Covered Lines: 5633
Relevant Lines: 25447

💛 - Coveralls

@voodoos voodoos merged commit 4c57c6a into ocaml:master Dec 2, 2024
6 checks passed
@yami-no-ryuu
Copy link

Is the reason for ocaml < 5.3 mentioned anywhere? Can't see a bug or comment.

@voodoos
Copy link
Collaborator Author

voodoos commented Jan 6, 2025

Is the reason for ocaml < 5.3 mentioned anywhere? Can't see a bug or comment.

That's because LSP versions for multiple OCaml versions are often incompatible between each others due to the reliance on Merlin and internal compiler libs. See #1386 for the branch compatible with 5.3 that is used for the preview (and soon final) releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants