Improve precision of duration field in view-metrics
#1565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-ats-d
changed the title
view-metrics
voodoos
approved these changes
Oct 16, 2025
Collaborator
voodoos
left a comment
voodoos
left a comment
There was a problem hiding this comment.
LGTM but the changelog is wrong.
voodoos
reviewed
Oct 16, 2025
Tim-ats-d
force-pushed
the
master
branch
3 times, most recently
from
7c6fc4b to
3be1268
Compare
Contributor
Author
|
Thank you 👍 |
davesnx
added a commit
to davesnx/ocaml-lsp
that referenced
this pull request
Nov 3, 2025
…rmat-mlx * 'master' of github.com:/ocaml/ocaml-lsp: Rename parameter used to configure nested bindings. (ocaml#1568) Upgrade to ocamlformat 0.28.1 (ocaml#1569) Improve precision of duration field in `view-metrics` (ocaml#1565) Make `code-lens` for toplevel let binding configurable (ocaml#1567) Fix 5.4 CI Enable support for OCaml 5.4 and prepare release 1.24.0 (ocaml#1559) Prepare release 1.23.1 (ocaml#1558)
davesnx
pushed a commit
to davesnx/ocaml-lsp
that referenced
this pull request
Nov 26, 2025
* Improve precision of metrics timestamp. * Add change entry. --------- Co-authored-by: Ulysse <[email protected]>
davesnx
pushed a commit
to davesnx/ocaml-lsp
that referenced
this pull request
Nov 26, 2025
* Improve precision of metrics timestamp. * Add change entry. --------- Co-authored-by: Ulysse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, current time was gathered with
Unix.timewhich has a resolution of one second. Since each LSP request responds take less than one second to be computed, the"dur"filed is always set to0in reported metrics.This patch uses
Unix.gettimeofdayto compute more precise timestamps.cc @voodoos