Rename parameter used to configure nested bindings #1568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-ats-d
changed the title
Tim-ats-d
force-pushed
the
configurable-internal-code-lens
branch
3 times, most recently
from
84125d9 to
da64744
Compare
xvw
approved these changes
Oct 27, 2025
Collaborator
|
@Tim-ats-d could you rebase on master so that the CI could run ? |
Tim-ats-d
force-pushed
the
configurable-internal-code-lens
branch
from
36eaf95 to
f6781f0
Compare
Collaborator
|
Thanks ! Also, I think we want a capability to ensure good support from the client side, wdyt @xvw |
Collaborator
|
Are capabilities really useful for configuration? Since the JSON decodeur allows extra fields? |
davesnx
added a commit
to davesnx/ocaml-lsp
that referenced
this pull request
Nov 3, 2025
…rmat-mlx * 'master' of github.com:/ocaml/ocaml-lsp: Rename parameter used to configure nested bindings. (ocaml#1568) Upgrade to ocamlformat 0.28.1 (ocaml#1569) Improve precision of duration field in `view-metrics` (ocaml#1565) Make `code-lens` for toplevel let binding configurable (ocaml#1567) Fix 5.4 CI Enable support for OCaml 5.4 and prepare release 1.24.0 (ocaml#1559) Prepare release 1.23.1 (ocaml#1558)
davesnx
pushed a commit
to davesnx/ocaml-lsp
that referenced
this pull request
Nov 26, 2025
davesnx
pushed a commit
to davesnx/ocaml-lsp
that referenced
this pull request
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the parameter was named with underscore (
for_nested_bindings) which cause a malformed displaying in the VSCcode options panel. This PR renames itforNestedBindingsfor the sake of uniformity with other parameters.