Add instructions to readme for installing with dune pkg #1573
Conversation
xvw
left a comment
xvw
left a comment
There was a problem hiding this comment.
Thanks! Is the version with eval (dune env) is already released?
|
Good catch, no it's not! I didn't realise that. This command will be added in dune.3.21.0 which should be released in the next few weeks. |
|
Heads up that the documentation here for ocaml-eglot suggests using |
Yes but there is a clear mention of the needed version:
I think your instructions deserve this mention of version number too :) |
| to make sure `ocamllsp` can analyze the code in the project. | ||
|
|
||
| To make sure your editor sees the correct instance of `ocamllsp` for the | ||
| project, run `eval $(dune tools env)` from your shell before launching your |
There was a problem hiding this comment.
dune tools env does not seem to work for me.
$ dune tools env
dune: unknown command 'env', must be one of 'exec', 'install' or 'which'.
Usage: dune tools COMMAND …
Try 'dune tools --help' or 'dune --help' for more information.
I'm using dune version 3.20.1
There was a problem hiding this comment.
Yes, that's the point of the following: #1573 (comment)
:)
There was a problem hiding this comment.
Sorry for the duplication. I just added a comment to the diff without checking if others had already complained.
Signed-off-by: Stephen Sherratt <[email protected]>
gridbugs
force-pushed
the
dune-pkg-doc
branch
from
931a235 to
55d472f
Compare
|
Updated instructions to add a minimum version number for dune. |
|
Thanks ! |
Signed-off-by: Stephen Sherratt <[email protected]>
4 participants
No description provided.