[Haiku] Unix socket test+single-thread setlocale+signals#14773
Open
Sylvain78 wants to merge 8 commits intoocaml:trunkfrom
Open
[Haiku] Unix socket test+single-thread setlocale+signals#14773Sylvain78 wants to merge 8 commits intoocaml:trunkfrom
Sylvain78 wants to merge 8 commits intoocaml:trunkfrom
Conversation
Add a filter for BeOS/Haiku Needed for a specific behaviour in unix abstract socket, tested in tests/lib-unix/unix-socket/recvfrom_<platform>.ml
- Add a specific filter 'beos_haiku' for tests - Specifif recv_from test in unix-socket, cause for abstract socket (created with "" as filename), haiku attributes them a random '\0xxxxx' (each x being a hex digit) name, so we are unable to test if socket is created with same "" filename as requested.
Sylvain78
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Adapt to not test unnamed socket on haiku cause those ones receive a random name with format "\000xxxxx", so the comparison of old and new filename can't succeed on Haiku.
-setlocale is not thread safe on Haiku (known bug on haiku side)
-sigio doesn't exist on Haiku