Merged
Conversation
4a57b76 to
ff98a10
Compare
jmid
reviewed
Apr 22, 2026
Member
jmid
left a comment
There was a problem hiding this comment.
Thanks! This LGTM, but I'm wondering about the strict equality constraint.
CI is failing
- to build
async_ssl.v0.17.0-1on Centos-10, Fedora-42 and Fedora-43 - to link with
core_unixduring building ofruntest
(none of these failures can be blamed on the release)
| "ppx_jane" | ||
| "async" | ||
| "cohttp-async" | ||
| "async_ssl" {= "v0.17.0-1"} |
Member
There was a problem hiding this comment.
Why this strict equality constraint for this specific (currently latest) version?
If another patch is released as v0.17.0-2 this wouldn't pick it up, unless we did a manual change.
Suggested change
| "async_ssl" {= "v0.17.0-1"} | |
| "async_ssl" {>= "v0.17.0-1"} |
Contributor
Author
There was a problem hiding this comment.
Yeah that's a great point, thanks for flagging. I've relaxed the dependency specification.
ff98a10 to
b29c73d
Compare
b29c73d to
88d4802
Compare
jmid
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openrouter_api.0.0.1OCaml client for the OpenRouter API
An Async-based OCaml client for OpenRouter (https://openrouter.ai), a unified API for LLMs from multiple providers (Anthropic, OpenAI, Google, and others). Covers chat completions (with streaming, tools, plugins, and structured outputs), text embeddings, and model listing.
🐫 Pull-request generated by opam-publish v3.0.0