Fix incorrect checksum for simple_httpd.1.0 (old version)#30123
Open
craff wants to merge 3 commits into
Open
Conversation
Member
|
also this PR consists of both a new release (1.1) and updates to the checksum of 1.0. maybe just do a 1.1 release and let the old release 1.0 be as is (or mark as unavailable, since it doesn't seem to be in the archives) so clients will choose 1.1 |
Contains a brittle test on json generation that fails all the time, unnecessarily polluting the CI output
```
File "test/pbt/dune", line 3, characters 43-58:
3 | test_json_stream_sizes test_classifiers test_sub_string
^^^^^^^^^^^^^^^
(cd _build/default/test/pbt && ./test_sub_string.exe)
Fatal error: exception File "test/pbt/test_sub_string.ml", line 35, characters 2-8: Assertion failed
(cd _build/default/test/pbt && ./test_json_stream_sizes.exe)
blitting with a lot of string boundaries: PASS
string-seq with a lot of string boundaries: PASS
File "test/pbt/dune", line 4, characters 3-27:
4 | json_roundtrip_in_binary)
^^^^^^^^^^^^^^^^^^^^^^^^
(cd _build/default/test/pbt && ./json_roundtrip_in_binary.exe)
json_json_roundtrip: FAIL
When given the input:
<float>
the test threw an exception:
File "test/pbt/json_roundtrip_in_binary.ml", line 92, characters 2-8: Assertion failed
Raised at Dune__exe__Json_roundtrip_in_binary.test_json in file "test/pbt/json_roundtrip_in_binary.ml", line 92, characters 2-17
Called from Crowbar.gen_apply.go.(fun) in file "src/crowbar.ml", line 352, characters 16-19
json_binary(bson)_roundtrip: FAIL
```
or
```
File "test/pbt/dune", lines 83-87, characters 0-111:
83 | (rule
84 | (alias runtest)
85 | (package data-encoding)
86 | (action
87 | (run node %{dep:./json_roundtrip_in_binary.bc.js})))
(cd _build/default/test/pbt && /usr/bin/node json_roundtrip_in_binary.bc.js)
json_json_roundtrip: FAIL
When given the input:
<float>
the test threw an exception:
File "test/pbt/json_roundtrip_in_binary.ml", line 92, characters 2-8: Assertion failed
json_binary(bson)_roundtrip: FAIL
When given the input:
<float>
the test threw an exception:
File "test/pbt/json_roundtrip_in_binary.ml", line 116, characters 28-34: Assertion failed
```
depending on the version.
See e.g. https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/72f51de94a07b75e147fd7a49002aebddd7c8ca8
Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
Contributor
Author
|
I removed 1.1, this was a manipulation error. |
Contributor
Author
|
Also I did not change the archive, I think the checksum was always wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.