Fix highlight hyphen leading operators

[gengar]

The "-" case always matches on "[^0-9>]" and never on latter.

[monnier]

The "-" case always matches on "[^0-9>]" and never on latter.

Could you show some example of the problem? AFAICT your patch changes the regexp such that subgroup 2 is always matched, which doesn't seem right.

[gengar]

OK, here is a example:

(let ((operator-char     "[-!$%&*+./:<=>?@^|~]")
      (operator-char-no> "[-!$%&*+./:<=?@^|~]"))
  (let ((reg1 (concat "\\(-\\)\\(?:[^0-9>]\\|\\("
                      operator-char-no> operator-char "*\\)\\)"))
        (reg2 (concat "\\(-\\)\\("
                      operator-char-no>
                      operator-char "*\\|\\(?:[^0-9>]\\)\\)"))
        (str "-$$$"))
    (string-match reg1 str)
    (print (match-string 0 str)) ; => "-$"
    (print (match-string 2 str)) ; => nil

    (string-match reg2 str)
    (print (match-string 0 str)) ; => "-$$$"
    (print (match-string 2 str)) ; => "$$$"
    nil))

I would expect to tuareg-mode highlights the whole symbol like -$$$.

[monnier]

Oh, I see what you mean now. But the patch is still incorrect because when the operator-char-no> operator-char * part does not match, we end up highlighting not just the - but also the subsequent char matched by [^0-9>].