Implement the new codelens.forNestedBindings setting

[Tim-ats-d]

Implement the new setting provided by this PR ocaml/ocaml-lsp#1567

[Copilot]

Pull Request Overview

This PR implements support for the new codelens.forNestedBindings LSP setting from ocaml-lsp, allowing users to control whether CodeLens appears on nested let bindings. The implementation also includes a breaking change by renaming the existing ocaml.server.codelens setting to ocaml.server.codelens.enable.

Key changes:

• Added codelens.forNestedBindings setting with a default value of false
• Renamed existing ocaml.server.codelens setting to ocaml.server.codelens.enable
• Introduced new OcamllspSettingCodeLens module to handle structured codelens configuration

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/settings.ml	Added new setting and updated codelens setting key from ocaml.server.codelens to ocaml.server.codelens.enable
src/settings.mli	Added interface declaration for the new nested bindings setting
src/vscode_ocaml_platform.ml	Read and pass the new nested bindings setting to the extension instance
src/extension_instance.ml	Store and propagate the nested bindings setting to the LSP client configuration
src/extension_instance.mli	Added parameter for nested bindings setting in configuration function
src/ocaml_lsp.ml	Replaced OcamllspSettingEnable with structured OcamllspSettingCodeLens module for codelens settings
src/ocaml_lsp.mli	Updated interface to use the new codelens settings structure
package.json	Updated configuration schema with renamed setting and new nested bindings option
CHANGELOG.md	Documented the breaking change and new feature

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[smorimoto]

LGTM

[Tim-ats-d]

There is an incompatibility between older versions of OCaml-lsp-server that do not implement the setting and the version of vscode-ocaml-platform that uses this patch. I'm trying to find a workaround.

It seems that this is not due to the difference in naming convention pointed out by Max (#1990 (comment)), even after fixing this, the problem is still present.

[Tim-ats-d]

The field forNestedBindings is now marked as optional in the JSON setting decoding. This no longer create incompatibility error when testing with previous OCaml LSP server version that does not handle the forNestedBindings option.

[Tim-ats-d]

Should be correct now, thank you @voodoos 👍

[smorimoto]

Thanks @Tim-ats-d!