fix: implement equals/hashCode for OceanBaseConfig to prevent cache invalidation #87
+104
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nvalidation Spark SQL cache relies on stable table identity. When OceanBaseCatalog.loadTable() creates new OceanBaseConfig instances each time, Spark's cache manager incorrectly invalidates cached query results if the config uses default reference equality. Changes: - Add equals() and hashCode() to OceanBaseConfig comparing stable identity fields (URL, username, schema, table) while avoiding sensitive fields like password - Add regression test testCacheTableDoesNotChangeAfterExternalInsert to verify cached table results remain stable after external data changes This fixes the issue where "CACHE TABLE xxx AS SELECT ..." would be unexpectedly refreshed when the underlying OceanBase table data changes externally. Resolves customer requirement for stable cache behavior in Spark 3.4.
Changes: - Added entries for Scala/Metals related files and directories - Included LocalTest.scala and set-test-env.sh to ignore list This improves the development environment by preventing unnecessary files from being tracked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Spark SQL cache relies on stable table identity. When OceanBaseCatalog.loadTable() creates new OceanBaseConfig instances each time, Spark's cache manager incorrectly invalidates cached query results if the config uses default reference equality.
Changes:
This fixes the issue where "CACHE TABLE xxx AS SELECT ..." would be unexpectedly refreshed when the underlying OceanBase table data changes externally.
Resolves customer requirement for stable cache behavior in Spark 3.4.
Solution Description