Skip to content

Creation of ION Functions Documentation Pages#44

Open
cwingard wants to merge 9 commits into
oceanobservatories:documentationfrom
cwingard:documentation
Open

Creation of ION Functions Documentation Pages#44
cwingard wants to merge 9 commits into
oceanobservatories:documentationfrom
cwingard:documentation

Conversation

@cwingard
Copy link
Copy Markdown
Member

@cwingard cwingard commented May 1, 2026

All here is the first draft of documentation for the ION Functions library. I've updated the doc strings in:

ctd_functions.py
flo_functions.py
co2_functions.py
ph_functions.py
phsen_h_functions.py
hyd_functions.py

using the existing DPS documentation to help further extend the documentation pages. You can see the results of the new documentation in my account: https://cwingard.github.io/ion-functions/. This is very much a work in progress and I am hoping to get feedback from folks as to the overall look and feel, direction and any suggested edits and tweaks.

The plan is to work through the code in batches over the course of the summer, with everything converted over and ready to merge into the master branch at that time. An additional goal is to create PyPi and conda-forge packages from the code that can be versioned (which can also be used to version the documentation).

Please do not merge this PR; I'll take care of that. Rather use this interface to provide feedback.

@jfram
Copy link
Copy Markdown

jfram commented May 3, 2026 via email

@cwingard
Copy link
Copy Markdown
Member Author

cwingard commented May 4, 2026

@jfram The DPS documents are listed in the References section for each page (and linked). Are you suggesting they be moved up higher into a separate section? Make them more visible?

Copy link
Copy Markdown

@wruef wruef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely laid out, the functions are cleaner and more readable, and the wiki is very nice.

Noting that calibrations.md is still a placeholder, every looks good to me.

Copy link
Copy Markdown

@mvardaro mvardaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this. It can be a little hard to distinguish between the "background" and "core functions" sections in the wiki pages, but the ToC on the left helps a lot. References seem clear, and I think it's fine to keep them at the end, but maybe there can be a pointer within the "Background" section to let users know where the info originates. Anyway, this is a good start and I like the approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants