improve greeting, profiles, and /etc/os-release#360
Merged
Conversation
this changes the awkward "Hi, I am hostname, a desktops" to the grammatically correct "Hi, I am hostname, a desktop"
the current nixosConfigurations implementation requires colmenaConfig to be an attribute set so that modules for each host in nixosConfigurations can be set to colmenaConfig.imports. this means that each host's config in colmenaHive cannot accept arguments like config, lib, or pkgs. setting nixosConfigurations directly to self.colmenaHive.nodes adds support for passing arguments to each host while being so much simpler. this also sets the hostname and hostid for each host in nixosConfigurations, which was previously skipped due to nixosConfigurations having modules = colmenaConfig.imports which skips the rest of colmenaConfig (where hostname and hostid is set, in addition to colmena specific options that were not imported in nixosConfigurations). (honestly this seems too good to be true. theres a reason this was not done before, right?)
since the ocf is basically acting as the vendor, we should set the os-release accordingly. this way, the documentation, support, bug report, etc urls that gui applications show will be ocf specific. fields like ID, NAME, CPE_NAME, etc are left as nixpkgs defaults since that is os information, not vendor.
the greeting was split from the motd so that it will not be printed twice (in both the greeting line and the motd) when logging in through agetty. however, ssh still needs to print it after login, so ssh gets a special motd with the greeting prepended to the motd like before.
the ocf color scheme includes california blue and gold, and cold colors like snow and ice. bright cyan is a good choice that respects the ocf color scheme and is widely compatible on terminals. it also happens to fit well with the nix color scheme too
BNH440
reviewed
Jul 6, 2026
BNH440
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
profiles/*.nixis now consistent withhosts/*hosts/is now what decides which profile is importedocf.releaseMetadata.enableoption/etc/os-releasenow includes ocf urls to be shown in gui applicationsnixosConfigurations = self.colmenaHive.nodes