fix(kobudai): disable nfsd delegations temporarily to fix old clients - #399
Merged
Conversation
Updated comments regarding NFS write delegations and linked relevant issues.
jaysa68
approved these changes
Aug 19, 2026
jaysa68
left a comment
jaysa68
left a comment
Member
There was a problem hiding this comment.
lgtm but i wont merge w/o SM approval @sophiebsw @BNH440
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 1, 2026
dotlambda
reviewed
Sep 1, 2026
24apricots
enabled auto-merge
September 1, 2026 17:08
24apricots
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in linux 6.6, nfsd added write delegations. however, this causes old clients to
get stuck spamming TEST_STATEID (~5000/s) causing open() to take multiple seconds:
https://gitlab.com/gitlab-org/gitlab-foss/-/work_items/52017
fixed client-side in linux 6.7, but death (and others) are super old (5.10 lol),
so let's disable delegations for now by disabling vfs leases.