Skip to content

Conversation

@himanshugoel2797
Copy link
Contributor

There have been some updates to components we rely on, which break things during compilation or execution:

  1. On the C/Python interface end, Python 3.13, which is the most current version, changed a function’s name (_PyLong_AsInt to PyLong_AsInt), causing compilation of SRW to fail .
  2. In srwl_uti_smp_rnd_obj2d.py, we import circle from skimage.draw, however, we don’t use it anywhere in the module. In recent versions, scikit-image has moved the circle class to elsewhere, so this causes an unnecessary error that is fixed by simply not importing circle.
  3. Some components of the Github Actions workflow file need small updates to keep the workflow working.
  4. Newer GCC versions have changed the default C standard used. This causes a compilation error for the Fortran code in genesis. This is fixed by passing -std=c99 -Wno-implicit-int to gcc when compiling genesis, allowing compilation to proceed. This should still be compatible with previous versions of gcc.
  5. I missed a ‘try: from . import …’ fix in one location, which causes matplotlib plotting to fail when an SRW script is executed in certain ways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant