Skip to content

[wasm] Option to implement OCaml strings with JavaScript strings #1772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

vouillon
Copy link
Member

@vouillon vouillon commented Dec 17, 2024

  • Conditional compilation of Wasm runtime
  • Import string constants (define JS strings in Wasm runtime)
  • default should be not to use js strings
  • Compatibilty for when JS string builtins proposal is not available
  • Performance improvements
    • skip conversions for ASCII strings
    • lower level version of caml_blit_string
    • Use I16 array for conversions
    • Remove unnecessary conversion
  • clean-up / check for missing tests
  • adapt Jane street libraries
  • performance measurements

@vouillon vouillon added the wasm label Dec 17, 2024
@vouillon vouillon force-pushed the js-strings branch 19 times, most recently from 7622533 to 1e6911d Compare December 20, 2024 18:03
@smorimoto smorimoto requested a review from Copilot December 29, 2024 20:07
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 59 out of 59 changed files in this pull request and generated no comments.

@vouillon vouillon force-pushed the js-strings branch 3 times, most recently from 770af3b to dcdb512 Compare March 21, 2025 14:21
@vouillon vouillon force-pushed the js-strings branch 2 times, most recently from 54f91c2 to dd3f973 Compare April 8, 2025 12:03
@vouillon vouillon force-pushed the js-strings branch 5 times, most recently from cae36fc to 7494238 Compare April 29, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant