Use dune-build-info to manage version information #1783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sora Morimoto <[email protected]>
hhugo
reviewed
Jan 6, 2025
| @@ -4,10 +4,9 @@ | |||
| (package js_of_ocaml-compiler) | |||
| (libraries | |||
| jsoo_cmdline | |||
| js_of_ocaml-compiler | |||
There was a problem hiding this comment.
js_of_ocaml-compiler is a (direct) dependency
hhugo
reviewed
Jan 6, 2025
| @@ -2,7 +2,7 @@ | |||
| (name jsoo_minify) | |||
| (public_name jsoo_minify) | |||
| (package js_of_ocaml-compiler) | |||
| (libraries jsoo_cmdline js_of_ocaml-compiler cmdliner compiler-libs.common) | |||
There was a problem hiding this comment.
js_of_ocaml-compiler is a direct dependency
|
|
@smorimoto, do you plan to work on this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of using
dune-build-infois to simplify managing the version of packages, but I still need a pointer because I don't know where to ideally place the version retrieval file.Ref: https://dune.readthedocs.io/en/stable/dune-libs.html#dune-build-info-library