Experiment: implement exceptions by returning null #1910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vouillon
force-pushed
the
return-exceptions
branch
2 times, most recently
from
16e4838 to
9387946
Compare
|
It certainly has an impact on microbenchmarks! Speaking of which, once again I only see microbenchmark results: https://bench.ci.dev/ocsigen/js_of_ocaml/pull/1910/base/master/benchmark/Wasm_of_ocaml?worker=autumn&image=bench.Dockerfile |
The PR with the other benchmarks has not been merged yet. |
vouillon
force-pushed
the
return-exceptions
branch
2 times, most recently
from
1d31a50 to
c523cbf
Compare
vouillon
force-pushed
the
return-exceptions
branch
from
c523cbf to
2aff70f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.