Skip to content

Backend Form: hide locale indicator for ruler field (align with section/hint) #5956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: 4.x
Choose a base branch
from
Open

Backend Form: hide locale indicator for ruler field (align with section/hint) #5956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6d58e3d
Form: hide locale indicator for rule
burzuy Oct 11, 2025
4e3b6ef
fix(backend/form): hide locale indicator for `rule`; render label/com…
burzuy Oct 11, 2025
1090809
fix(backend/form): add 'ruler' to showFieldLabels exclusions (no loca…
burzuy Oct 12, 2025
487987d
fix(backend/form): use correct type 'ruler'
burzuy Oct 12, 2025
8d72eef
Update _field_ruler.php
burzuy Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/backend/widgets/Form.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1065,7 +1065,7 @@ protected function getFieldDepends($field): string
*/
protected function showFieldLabels(FormField $field): bool
{
if (in_array($field->type, ['checkbox', 'switch', 'section', 'hint'])) {
if (in_array($field->type, ['checkbox', 'switch', 'section', 'hint', 'ruler'])) {
return false;
}

Expand Down
10 changes: 10 additions & 0 deletions modules/backend/widgets/form/partials/_field_ruler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,14 @@
<!-- Horizontal Rule -->
<?php if ($field->label): ?>
<label for="<?= $field->getId() ?>" class="form-label">
<?= e(__($field->label)) ?>
</label>
<?php endif ?>
<div class="field-horizontalrule">
<hr />
</div>
<?php if ($field->comment): ?>
<p class="form-text">
<?= $field->commentHtml ? trans($field->comment) : e(__($field->comment)) ?>
</p>
<?php endif ?>