Open
Conversation
evb123
reviewed
Sep 25, 2023
evb123
left a comment
evb123
left a comment
There was a problem hiding this comment.
Looks great! Some comments, please review :)
| @@ -0,0 +1,15 @@ | |||
| WITH orders AS ( | |||
| SELECT | |||
| * | |||
There was a problem hiding this comment.
we usually encourage only necessary columns to be select as high up in he query as possible (but not a blocker)
| ) | ||
|
|
||
| SELECT | ||
| TRUNC(first_order, "MM") AS first_order_month |
There was a problem hiding this comment.
if first_order is a timesamp, it should be localised before truncation :)
| - not_null | ||
| - name: first_name_hash | ||
| tests: | ||
| - dbt_expectations.expect_column_to_exist |
| version: 2 | ||
|
|
||
| models: | ||
| - name: stg_customers_pii |
There was a problem hiding this comment.
We're missing a sensitive config on this _PII table (how do we know to put this model in consumer_sensitive db?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.