Open
Conversation
Here are the fixes that need implementing: 1. All .yml files should be renamed to specify what they apply to. 2. Staging models should be split by which source they are coming from. 3. stg_customers contains PII data in the first_name and last_name columns so these need to be hashed. 4. The customers.sql and orders.sql models moced to warehouse folder 5. dbt_project_evaluator_exceptions.csv to make an except for stg_customers referecing stg_customers_pii
Finance - Total value of orders returned by customer Sales - The customer count by month for customers making their first order
This reverts commit bc906b5.
evb123
reviewed
Dec 7, 2023
evb123
left a comment
evb123
left a comment
There was a problem hiding this comment.
Sensitive folders are legacy - now we put sensitive models directly in layer folders :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.