Skip to content

fix(package): only pack needed files#1035

Merged
wolfy1339 merged 1 commit intooctokit:mainfrom
Bo98:slim-package
Nov 24, 2025
Merged

fix(package): only pack needed files#1035
wolfy1339 merged 1 commit intooctokit:mainfrom
Bo98:slim-package

Conversation

@Bo98
Copy link
Copy Markdown
Contributor

@Bo98 Bo98 commented Nov 24, 2025

Resolves #1034


Before the change?

$ npm pack --dry-run
npm warn gitignore-fallback No .npmignore file found, using .gitignore for file exclusion. Consider creating a .npmignore file to explicitly control published files.
npm notice
npm notice 📦  @octokit/graphql-schema@0.0.0-development
npm notice Tarball Contents
npm notice 1.4kB .github/ISSUE_TEMPLATE/bug.yml
npm notice 1.6kB .github/ISSUE_TEMPLATE/documentation.yml
npm notice 1.6kB .github/ISSUE_TEMPLATE/feature.yml
npm notice 1.6kB .github/ISSUE_TEMPLATE/maintenance.yml
npm notice 880B .github/pull_request_template.md
npm notice 52B .github/renovate.json
npm notice 529B .github/workflows/add_to_octokit_project.yml
npm notice 847B .github/workflows/codeql-analysis.yml
npm notice 1.4kB .github/workflows/immediate-response.yml
npm notice 861B .github/workflows/release.yml
npm notice 466B .github/workflows/test.yml
npm notice 730B .github/workflows/update-graphql-codegen.yml
npm notice 663B .github/workflows/update-prettier.yml
npm notice 1.9kB .github/workflows/update.yml
npm notice 3.2kB CODE_OF_CONDUCT.md
npm notice 2.4kB CONTRIBUTING.md
npm notice 1.1kB LICENSE.md
npm notice 1.7kB README.md
npm notice 893B SECURITY.md
npm notice 1.1kB bin/download.js
npm notice 337B index.d.ts
npm notice 312B index.js
npm notice 349B lib/validate.js
npm notice 2.0kB package.json
npm notice 1.3MB schema.d.ts
npm notice 1.2MB schema.graphql
npm notice 5.0MB schema.json
npm notice 45B test/index.js
npm notice 213B test/smoke.js
npm notice 350B test/typescript-validate.ts
npm notice 415B test/validate.js

After the change?

$ npm pack --dry-run
npm notice
npm notice 📦  @octokit/graphql-schema@0.0.0-development
npm notice Tarball Contents
npm notice 1.1kB LICENSE.md
npm notice 1.7kB README.md
npm notice 337B index.d.ts
npm notice 312B index.js
npm notice 349B lib/validate.js
npm notice 2.1kB package.json
npm notice 1.3MB schema.d.ts
npm notice 1.2MB schema.graphql
npm notice 5.0MB schema.json

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

I considered whether it was necessary to ship bin but d8789be clearly demonstrates that it's an internal tool closely tied to CI. If it were an external tool then that commit, which shipped in a patch release, would have been seen as a breaking change. As such, this should not be a breaking change either and the script shouldn't ship with the npm package. It also was never added to the bin field of package.json anyway.


@github-actions
Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 merged commit 5f014c9 into octokit:main Nov 24, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from 🆕 Triage to ✅ Done in 🧰 Octokit Active Nov 24, 2025
@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 15.26.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Bo98 Bo98 deleted the slim-package branch November 24, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

[MAINT]: Package contains unnecessary project files

3 participants