Skip to content

[Fix] Fix route for TeamPermissionsForARepository() #3004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tarzenda
Copy link

The leading slash resulted in ApiValidationExceptions when attempting to add a team to a repository.

Resolves #3002

In Octokit/Helpers/ApiUrls.cs, method TeamPermissionsForARepository() returns an erroneous leading slash in the URI it constructs; this leads methods that use it to fail as described below. This should instead be a relative URI like all other methods in the class (with the exception of EnterpriseManagementConsoleMaintenance() which is a documented special case).


Before the change?

After the change?

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Tests have been updated/fixed as well.
No documentation impacts that I can tell.

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

The leading slash resulted in ApiValidationExceptions when attempting to add a team to a repository.
@nickfloyd nickfloyd moved this from 🆕 Triage to 👀 In review in 🧰 Octokit Active Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

[BUG]: ApiValidationException when attempting to add/remove a team to/from a repository
1 participant