fix: Check for empty spaces and illegal characters in JSON body of error responses #1776
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1777
I noticed that sometimes GitHub returns
" "
string (string with one empty space) or"<illegal-character>{}"
in error responses, which leads toJson::ParseError
exceptions.If we
#strip
the body and check that it starts with{
, we will avoid errors down the road.WDYT?
Before the change?
" "
.After the change?
Json::ParseError
exceptions.Pull request checklist
Does this introduce a breaking change?
No
Please see our docs on breaking changes to help!