Skip to content

Conversation

Lokideos
Copy link

@Lokideos Lokideos commented Sep 18, 2025

Resolves #1777

I noticed that sometimes GitHub returns " " string (string with one empty space) or "<illegal-character>{}" in error responses, which leads to Json::ParseError exceptions.
If we #strip the body and check that it starts with {, we will avoid errors down the road.
WDYT?


Before the change?

After the change?

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

No

Please see our docs on breaking changes to help!

  • Yes
  • No

Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@Lokideos Lokideos changed the title fix: Remove empty spaces from JSON body fix: Check for empty spaces and illegal characters in JSON body of error responses Sep 18, 2025
@Lokideos Lokideos force-pushed the lokideos/fix-remove-empty-spaces-from-string-body branch from 299b130 to 3a14f13 Compare September 19, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🆕 Triage

Development

Successfully merging this pull request may close these issues.

[BUG]: GitHub sometimes returns " " or illegal characters in body in error response

1 participant