Skip to content

Boolean from response should include all successful 2XX response codes #1791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PatBanks wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Boolean from response should include all successful 2XX response codes #1791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4b95e3
Boolean From Response should include 200 as a valid response code
PatBanks Dec 19, 2025
7237a37
use the full 2XX range
PatBanks Dec 19, 2025
a970e2d
unexpected response codes should not be in 200 range
PatBanks Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/octokit/connection.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ module Connection

# Header keys that can be passed in options hash to {#get},{#head}
CONVENIENCE_HEADERS = Set.new(%i[accept content_type])
SUCCESSFUL_RESPONSES = (200..299)

# Make a HTTP GET request
#
Expand Down Expand Up @@ -167,7 +168,7 @@ def request(method, path, data, options = {})
# @return [Boolean] True on success, false otherwise
def boolean_from_response(method, path, options = {})
request(method, path, options)
[201, 202, 204].include? @last_response.status
SUCCESSFUL_RESPONSES.cover? @last_response.status
rescue Octokit::NotFound
false
end
Expand Down
4 changes: 2 additions & 2 deletions spec/octokit/client/actions_workflow_runs_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@
end

it 'returns false if request returns unexpected status' do
request = stub_post("repos/#{@test_repo}/actions/runs/#{@run_id}/rerun").to_return(status: 205)
request = stub_post("repos/#{@test_repo}/actions/runs/#{@run_id}/rerun").to_return(status: 300)

response = @client.rerun_workflow_run(@test_repo, @run_id)

Expand All @@ -124,7 +124,7 @@
end

it 'returns false if the request returns unexpected status' do
request = stub_post("repos/#{@test_repo}/actions/runs/#{@run_id}/cancel").to_return(status: 205)
request = stub_post("repos/#{@test_repo}/actions/runs/#{@run_id}/cancel").to_return(status: 300)

response = @client.cancel_workflow_run(@test_repo, @run_id)

Expand Down