improve types #686
Open
improve types #686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know, this is horrible code. Dont judge me on this. Basically generating the types once at build time and should reduce the calculations on the local dev machine.
before:
> npx tsc --project tsconfig.test.json Files: 124 Lines of Library: 38837 Lines of Definitions: 122196 Lines of TypeScript: 7783 Lines of JavaScript: 0 Lines of JSON: 0 Lines of Other: 0 Identifiers: 101755 Symbols: 113920 Types: 56762 Instantiations: 126887 Memory used: 209521K Assignability cache size: 13949 Identity cache size: 0 Subtype cache size: 1 Strict subtype cache size: 4 I/O Read time: 0.03s Parse time: 0.44s ResolveModule time: 0.01s ResolveTypeReference time: 0.00s ResolveLibrary time: 0.01s Program time: 0.53s Bind time: 0.19s Check time: 1.75s printTime time: 0.00s Emit time: 0.00s Total time: 2.47safter:
> tsc --project tsconfig.test.json Files: 130 Lines of Library: 10710 Lines of Definitions: 4193 Lines of TypeScript: 60137 Lines of JavaScript: 0 Lines of JSON: 0 Lines of Other: 0 Identifiers: 44194 Symbols: 39228 Types: 20329 Instantiations: 2406 Memory used: 104601K Assignability cache size: 6257 Identity cache size: 0 Subtype cache size: 1 Strict subtype cache size: 4 I/O Read time: 0.01s Parse time: 0.26s ResolveModule time: 0.01s ResolveTypeReference time: 0.00s ResolveLibrary time: 0.02s Program time: 0.32s Bind time: 0.09s Check time: 0.79s transformTime time: 0.09s printTime time: 0.00s Emit time: 0.00s Total time: 1.21sResolves #ISSUE_NUMBER
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!