Process CSS content before erasing file for writing #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should eliminate the "flash of unstyled content" when compiling Jekyll sites that use this plugin.
Author
|
@imathis any update on getting this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am using this plugin for my Jekyll-based personal site, and it works well for the most part. However, I've noticed a "flash of unstyled content" on my site when I reload the page before my Jekyll build finishes (which happens quite often, since this plugin seems to lengthen my build time substantially, and it's more difficult for me to intuitively guess when my build is done).
Fortunately, I found the cause of the issue by examining your source code. Recall that opening a file in 'w' mode initially erases the file. In this case, the file was being prefixed after the file was opened, meaning that the file would be empty for as long as the
AutoprefixerRails.processfunction would take to execute. This also implies that if theAutoprefixerRails.processfunction raises an exception, then the file will remain empty.As you can see, I have submitted in this PR the simple fix (which involves processing the file before opening it for writing). @imathis, please consider merging this in and drafting new release.
Thanks,
Caleb