Use repository configuration of user.name and user.email for deploy commits #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original repo may have it's own user configuration, which should be inherited in the deployment repo. This commits add the user config copy logic.
In git.rb, check_deploy_dir method was called but did nothing, so removed it; it is called in init_repo method, but the result of it does not affect the execution logic. If the check is failse, then the init_repo method does nothing anyway.
Yuki-Inoue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the deploy repository's commit is always done by using global "user.name" and "user.email"; even if these configs exists in the parent octopress repository, they are not used. This is a trouble if user wants to configure the deployed committer name/email on repository basis.
This PR fix that behavior and use the octopress repository's user configuration for making the commits.