Fixes deprecation warning on categories and tags #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point, Jekyll moved the categories and tags for a post into the data hash, deprecating the accessors. Using p.categories or p.tags for accessing the list of categories or tags for a post p has been deprecated for a while, being the data hash p['categories'] / p['posts'] the preferred way for accesing those parameters. This commit uses the data hash instead of the accessors to avoid the noisy deprecation warnings that log a lot of warnings during the compilation of a site.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of noisy deprecations are being logged during site compilation when building a Jekyll site. I have been able to reproduce this for a few Jekyll versions. During compilation, the following message is logged several times per build:
It appears that the more pages in the main loop, the more times this message is logged. When serving a site using the --watch option, there are so many deprecation warnings that it makes hard to debug other issues with the site or to inspect the logs.
This PR fixes this behaviour by using the new syntax proposed in Jekyll to access the categories and the tags for a post, removing the deprecation messages.
I've successfully tested this to work by using the test suite provided with this gem and by using a patched version of octopress-paginate with this PR applied to build my site and in both cases the deprecation messages are gone. CI tests will still fail because the test suite has other unrelated errors.