Skip to content

Speed up event replaying #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 17, 2024
Merged

Speed up event replaying #669

merged 17 commits into from
Jul 17, 2024

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented Jul 16, 2024

Contents (#669)

Enhancements

  • Skip non-result event validation if only result is required
  • Add ability to skip event validation in event handlers
  • Make diagnostics log messages more consistent
  • Allow instantiation of Diagnostics, Topic, Subscription, and GoogleCloudPubSubEventHandler without cloud credentials

Refactoring

  • Update from deprecated datetime.datetime.utcnow method
  • Use cached_property in Service
  • Remove unused attributes on MockService and Runner

Testing

  • Implement MockSubscription.delete

@cortadocodes cortadocodes self-assigned this Jul 16, 2024
@cortadocodes cortadocodes linked an issue Jul 16, 2024 that may be closed by this pull request
@cortadocodes cortadocodes linked an issue Jul 16, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 90.19608% with 5 lines in your changes missing coverage. Please review.

Project coverage is 94.54%. Comparing base (ed77f40) to head (c8e8b67).
Report is 1 commits behind head on main.

Files Patch % Lines
octue/cloud/pub_sub/subscription.py 77.77% 2 Missing ⚠️
octue/cloud/pub_sub/topic.py 77.77% 2 Missing ⚠️
octue/cloud/emulators/_pub_sub.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
- Coverage   94.55%   94.54%   -0.01%     
==========================================
  Files          83       83              
  Lines        3546     3559      +13     
==========================================
+ Hits         3353     3365      +12     
- Misses        193      194       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cortadocodes cortadocodes linked an issue Jul 17, 2024 that may be closed by this pull request
@cortadocodes cortadocodes merged commit 84b418a into main Jul 17, 2024
5 checks passed
@cortadocodes cortadocodes deleted the speed-up-event-replaying branch July 17, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed up event replayer Make octue services easy to test and patch Update from deprecated utcnow method
2 participants