-
Notifications
You must be signed in to change notification settings - Fork 4
Improve event filtering #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Set `validate_events=True` in the `EventReplayer` constructor to retain the previous behaviour.
BREAKING CHANGE: To filter by one event kind as before, use `kinds=[event_kind]` instead of `kind=event_kind`.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #673 +/- ##
==========================================
- Coverage 94.50% 94.49% -0.01%
==========================================
Files 83 83
Lines 3547 3577 +30
==========================================
+ Hits 3352 3380 +28
- Misses 195 197 +2 ☔ View full report in Codecov by Sentry. |
skipci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contents (#673)
IMPORTANT: There are 2 breaking changes.
New features
dictionary_product
utility functionEnhancements
EventReplayer
by defaultget_events
get_events
AbstractEventHandler
and subclassesThreadPoolExecutor
context managersUpgrade instructions
💥 Disable event validation in `EventReplayer` by default
Set
validate_events=True
in theEventReplayer
constructor to retain the previous behaviour.💥 Enable filtering by multiple event kinds in `get_events`
To filter by one event kind as before, use
kinds=[event_kind]
instead ofkind=event_kind
.