Skip to content

Log warning when runtime timeout is near #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 16, 2024

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented Dec 16, 2024

Contents (#690)

Enhancements

  • Log warning when running on on Cloud Run and runtime timeout (1 hour) is near

Dependencies

  • Add pydash dependency

Refactoring

  • Replace custom nested attribute functions with pydash usage

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.65%. Comparing base (9092646) to head (a9d7888).
Report is 97 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #690      +/-   ##
==========================================
+ Coverage   94.50%   94.65%   +0.14%     
==========================================
  Files          83       83              
  Lines        3547     3590      +43     
==========================================
+ Hits         3352     3398      +46     
+ Misses        195      192       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cortadocodes cortadocodes linked an issue Dec 16, 2024 that may be closed by this pull request
@cortadocodes cortadocodes marked this pull request as ready for review December 16, 2024 12:19
@cortadocodes cortadocodes self-assigned this Dec 16, 2024
@cortadocodes cortadocodes merged commit 2142ceb into main Dec 16, 2024
5 checks passed
@cortadocodes cortadocodes deleted the warn-about-runtime-timeout branch December 16, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace custom nested functions with pydash.get/pydash.set_
2 participants