Skip to content

Rename project_name to project_id #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented May 13, 2025

Contents (#731)

IMPORTANT: There is 1 breaking change.

Refactoring

  • 💥 BREAKING CHANGE: Rename project_name to project_id
  • Remove unused test environment variable TEST_PROJECT_ID

Operations

  • Stop using tox for CI tests

Dependencies

  • Use version 0.16.0 of service communication schema
  • Use twined=^0.7.0
  • Remove tox

Upgrade instructions

💥 Rename `project_name` to `project_id`

Rename the project_name argument to project_id

BREAKING CHANGE: Swap the `project_name` argument with `project_id`
@cortadocodes cortadocodes self-assigned this May 13, 2025
cortadocodes added a commit to octue/twined that referenced this pull request May 13, 2025
BREAKING CHANGE: Replace `project_name` with `project_id` (see octue/octue-sdk-python#731 for more info).
@cortadocodes cortadocodes force-pushed the rename-project-name-to-project-id branch from 0e3ec5f to afecf9d Compare May 13, 2025 16:55
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.12%. Comparing base (cd8a6ca) to head (afecf9d).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
octue/cli.py 71.42% 2 Missing ⚠️
octue/runner.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #731      +/-   ##
==========================================
+ Coverage   94.05%   94.12%   +0.06%     
==========================================
  Files          85       85              
  Lines        3685     3659      -26     
==========================================
- Hits         3466     3444      -22     
+ Misses        219      215       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants