Skip to content

[4] Additional properties prevented #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: rpm-and-tilt-not-required
Choose a base branch
from
Open

[4] Additional properties prevented #90

wants to merge 8 commits into from

Conversation

thclark
Copy link
Contributor

@thclark thclark commented Apr 29, 2025 •
edited by github-actions bot
Loading

Contents (#90)

New features

Enhancements

  • Make design_basis section optional
  • The rotor_tilt prop is no longer required
  • Rated and cut in rpm properties are no longer required
  • Constrain the ability to pass with additional properties
  • Add legend to deratings to allow additiona context data
  • Make examples consistent

Fixes

  • Consistent and more flexible legend schema for the derating curves

Testing

  • Fix test case extraction of subschema

@thclark thclark force-pushed the additional-properties branch from e73dbd4 to b821382 Compare April 29, 2025 14:26
@thclark thclark changed the title [DRAFT] Additional properties prevented [4] Additional properties prevented Apr 29, 2025
@thclark thclark changed the base branch from main to rpm-and-tilt-not-required May 2, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenholleran stephenholleran stephenholleran left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Thermal shutdown -> thermal regulation
2 participants
@thclark @stephenholleran