Enable -warn-error +partial-match by default to ensure changes in a dependency do not lead into unforseen runtime failures #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ependency do not lead into unforseen runtime failures
shonfeder
force-pushed
the
warn-error-partial-match
branch
from
5967b2e to
1b17be8
Compare
shonfeder
approved these changes
Jun 20, 2024
Member
shonfeder
left a comment
shonfeder
left a comment
There was a problem hiding this comment.
Sounds like a good idea to me!
Contributor
Author
|
Requires ocaml/dune#10489 (also a way to disable this feature for dune < "whatever version this is going to be fixed in") |
Member
|
I see. Converted this to a draft in that case. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ocaml/ocaml#12475
Having this would've prevented ocaml/opam-repository#24467 from occurring and warned the mdx maintainers that their package is not compatible yet.