Skip to content

Comments

Dummy data#31

Merged
burnout87 merged 2 commits intomasterfrom
dummy-data
Mar 21, 2025
Merged

Dummy data#31
burnout87 merged 2 commits intomasterfrom
dummy-data

Conversation

@burnout87
Copy link
Contributor

No description provided.

Copy link
Member

@dsavchenko dsavchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe adding it and using as package data is the best option here. Then no need for chart changes (at least regarding SPI-ACS. If other integral plugins need external dummy data, then better to be consistent in a way we deal with it)

@volodymyrss
Copy link
Member

I thought about package daya and it is indeed a good choice for spiacs, but for other integral plugin dummy data is too large. So for consistency putting right into dispatcher container seems better.

@burnout87
Copy link
Contributor Author

burnout87 commented Mar 18, 2025

I thought about package daya and it is indeed a good choice for spiacs, but for other integral plugin dummy data is too large. So for consistency putting right into dispatcher container seems better.

That it is indeed my idea, having it in the container, getting the file directly from the repo.

The only change in the chart serves the purpose of aligning the dummy_cache parameter with the other integral instruments

@volodymyrss
Copy link
Member

I thought about package daya and it is indeed a good choice for spiacs, but for other integral plugin dummy data is too large. So for consistency putting right into dispatcher container seems better.

That it is indeed my idea, having it in the container, getting the file directly from the repo.

The only change in the chart serves the purpose of aligning the dummy_cache parameter with the other integral instruments

Just when the data is big, it's better not to keep it in the repo. It can be fetched on container build, from some static storage.

@dsavchenko
Copy link
Member

Then the way I see it is to put it in a volume on container init (if not already there). To not grow container size.

@burnout87
Copy link
Contributor Author

Then the way I see it is to put it in a volume on container init (if not already there). To not grow container size.

But the size won't grow significantly. In the end, it's just a small text file

@volodymyrss
Copy link
Member

Then the way I see it is to put it in a volume on container init (if not already there). To not grow container size.

You have to deploy it every time you deploy the container. So why not just include in the container. It can be tens of Mb, so too large for git or package data, but small enough for >500Mb (at best) container.

@dsavchenko
Copy link
Member

Then the way I see it is to put it in a volume on container init (if not already there). To not grow container size.

You have to deploy it every time you deploy the container. So why not just include in the container. It can be tens of Mb, so too large for git or package data, but small enough for >500Mb (at best) container.

Ah, ok. Tens of Mb is not a problem, of course.

@volodymyrss
Copy link
Member

@burnout87 , please change the container with the dummy prods for spi-acs?

@burnout87
Copy link
Contributor Author

burnout87 commented Mar 21, 2025

@burnout87 , please change the container with the dummy prods for spi-acs?

if they're added to the same archive of the other integral instruments (https://github.com/oda-hub/dispatcher-container/blob/993e2bbab97f59605063eaaeca139a923226e5f3/Dockerfile#L61-L62), then this PR is not needed, or did you have another approach in mind?

@burnout87
Copy link
Contributor Author

@burnout87 , please change the container with the dummy prods for spi-acs?

if they're added to the same archive of the other integral instruments, then this PR is not needed, or did you have another approach in mind?

the other option, is to request those from github directly

@volodymyrss
Copy link
Member

@burnout87 , please change the container with the dummy prods for spi-acs?

if they're added to the same archive of the other integral instruments, then this PR is not needed, or did you have another approach in mind?

the other option, is to request those from github directly

For simplicity, please add this one from github. It's small and is already there.

@burnout87
Copy link
Contributor Author

burnout87 commented Mar 21, 2025

@burnout87 , please change the container with the dummy prods for spi-acs?

if they're added to the same archive of the other integral instruments, then this PR is not needed, or did you have another approach in mind?

the other option, is to request those from github directly

For simplicity, please add this one from github. It's small and is already there.

ok then let's merge this and I will make the change in the container

@burnout87 burnout87 merged commit fe73037 into master Mar 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants