Skip to content

chore: plumbing upgrade 2026-08-02 - #496

Merged
DennisAlund merged 3 commits into
mainfrom
chore/plumbing-upgrade-2026-08-02
Aug 7, 2026
Merged

chore: plumbing upgrade 2026-08-02#496
DennisAlund merged 3 commits into
mainfrom
chore/plumbing-upgrade-2026-08-02

Conversation

@DennisAlund

@DennisAlund DennisAlund commented Aug 2, 2026

Copy link
Copy Markdown
Member

This PR was generated by the scheduled plumbing-upgrade job.

SDK bumps

None. Both Facebook SDK pins already cover the latest release in their tracked major (v18.x per repo policy):

Component Pin Latest upstream Change
com.facebook.android:facebook-android-sdk [18.0,19.0) 18.3.0 none — already covered
FBSDKCoreKit (CocoaPods) ~> 18.0 18.1.0 none — already covered
FBSDKCoreKit (SPM) "18.0.0"..<"19.0.0" 18.1.0 none — already covered
FBAudienceNetwork n/a n/a still not a dependency (dropped previously); verified absent from the podspec

Build tooling bumps

Component Old New
Kotlin 2.4.0 2.4.10
Android Gradle Plugin 8.13.0 8.13.0 (unchanged — already the latest 8.x release; AGP 9.x exists upstream but the repo's own CI (build-verify.yml) still treats AGP 9 as an experimental, allowed-to-fail matrix cell, so flipping the example's default toolchain to AGP 9 was left out of this automated run as a deliberate maintainer staging decision, not a plumbing bump)
Gradle wrapper 8.13 8.13 (unchanged — intentionally paired with AGP per the existing # AGP 8.13.x pairs with Gradle 8.13 comment; a newer 8.14.5 patch exists but wasn't pulled in isolation since it can't be verified in this environment)
Android compileSdk / targetSdk 36 / 36 36 / 36 (unchanged — already the latest stable Android API level)
minSdk 21 21 (unchanged)
iOS deployment target (plugin: podspec / Package.swift) 13.0 13.0 (unchanged — no SDK bump requires a higher floor)
iOS deployment target (example Xcode project) 12.0 13.0 (fixed — see below)
Swift tools-version 5.9 5.9 (unchanged)
Flutter / Dart SDK constraint >=3.38.0 / >=3.3.0 <4.0.0 unchanged (no new API requires raising the floor)

Files touched

  • example/android/build.gradle — Kotlin 2.4.0 → 2.4.10
  • example/android/settings.gradle — Kotlin 2.4.0 → 2.4.10
  • example/ios/Runner.xcodeproj/project.pbxprojIPHONEOS_DEPLOYMENT_TARGET 12.0 → 13.0 (6 build-config entries)
  • pubspec.yaml — version 0.30.4 → 0.30.5
  • ios/facebook_app_events.podspec — version 0.30.4 → 0.30.5
  • example/pubspec.lock — path-dependency version 0.30.4 → 0.30.5
  • CHANGELOG.md — new 0.30.5 entry

Source code changes forced by the SDK bump

None — no Kotlin/Swift source changes were needed this round.

Verification

  • Final grep sweep across the plugin and example for the Facebook Maven coordinate, iOS pod/SPM dependency declarations, every deployment_target/IPHONEOS_DEPLOYMENT_TARGET, and every compileSdk/targetSdk/minSdk — all consistent after the edit (this is what caught the stale example IPHONEOS_DEPLOYMENT_TARGET = 12.0).
  • gradle -v — confirms Gradle is invocable in this environment (Gradle 8.14.3 tool on PATH, unrelated to the project's own wrapper pin).

Verification skipped

  • flutter pub get (root and example), flutter analyze, flutter test, Android assembleDebug of the example — no Flutter/Dart SDK is installed in this execution environment (flutter/dart not found on PATH), so none of these could be run.
  • Refreshing example/ios/Podfile.lock — no CocoaPods (pod) toolchain available in this environment; left untouched. It's currently pinned to FBSDKCoreKit 18.0.0, one patch behind the latest 18.1.0 the pin range already allows — a normal pod update FBSDKCoreKit by a maintainer with CocoaPods available would pick that up.

Plugin version

Old: 0.30.4 (released on main while this PR was open) → New: 0.30.5

CHANGELOG entry (verbatim):

## 0.30.5

- **Update Android toolchain** — Kotlin 2.4.10 (was 2.4.0). AGP (8.13.0, already the latest 8.x release) and `compileSdk`/`targetSdk` (36, already the latest stable API level) are unchanged. Gradle stays pinned at 8.13, matched to AGP 8.13.x per the existing wrapper convention, even though a newer 8.14.x patch is available upstream. The Facebook Android SDK Maven range (`[18.0,19.0)`) already covers the latest 18.x release (18.3.0) and the iOS CocoaPods/SPM `~> 18.0` / `"18.0.0"..<"19.0.0"` pins already cover the latest 18.x release (18.1.0), so no Facebook SDK dependency changes were needed this round.
- Raise the example app's iOS deployment target from 12.0 to 13.0 to match the plugin's actual minimum (`s.ios.deployment_target` in the podspec and `Package.swift` have required iOS 13 since 0.26.0); the example's Xcode project setting had never been updated to match.

Merge conflict resolution (2026-08-07)

main moved while this PR was open: PR #497 landed, then main was released as 0.30.4 (commit 3ab9184, tag v0.30.4). This branch had also claimed 0.30.4, so it needed both a textual and a semantic fix.

  • Textual conflict — CHANGELOG.md. Both sides added a top section. Resolved by keeping both: this branch's plumbing entry moves to a new ## 0.30.5 heading, sitting above the released ## 0.30.4 codeless-manifest entry from main. Nothing from either side was dropped.
  • Semantic conflict — the version bump. This one merged cleanly and was therefore the dangerous half: both sides wrote the identical literal 0.30.4 into pubspec.yaml, ios/facebook_app_events.podspec and example/pubspec.lock, so git saw no conflict at all and would have shipped a second, different 0.30.4 over an already-tagged release. All three are now 0.30.5, kept in sync per the CONTRIBUTING.md release process.

Verified after the merge that git diff origin/main HEAD is identical to git diff origin/main...HEAD — i.e. the merge reverted nothing from main; the PR's net effect is still only the seven plumbing files.

The two Copilot review points (Gradle "latest stable" wording, stale example/pubspec.lock) were already addressed in 78beafc and survive the merge intact.

Reviewer notes

  • The public Dart API is unchanged — no edits under lib/, no new/renamed/resignatured methods.
  • The CocoaPods spec (~> 18.0) and the SPM manifest ("18.0.0"..<"19.0.0") remain in lockstep — neither was touched this round since both already cover the latest 18.x release.
  • Deferred: bumping the example's default Android toolchain to AGP 9.x + Gradle 9.x. This is technically the latest upstream, but the repo's CI already exercises AGP 9 as a separate, explicitly experimental/allowed-to-fail matrix cell (see build-verify.yml), which reads as an intentional, maintainer-paced rollout rather than something this automated job should preempt by flipping the default.
  • Deferred: example/ios/Podfile.lock refresh to pick up FBSDKCoreKit 18.0.0 → 18.1.0 (still within the existing ~> 18.0 pin) — no CocoaPods toolchain was available to regenerate it safely in this run.

Generated automatically by the scheduled plumbing-upgrade job. Closing this PR is safe — the next scheduled run will start fresh from the default branch rather than resuming this branch.


Generated by Claude Code

Bump Kotlin to 2.4.10 (was 2.4.0) in the example's Android toolchain and
raise the example iOS project's IPHONEOS_DEPLOYMENT_TARGET to 13.0 to
match the plugin's actual minimum (podspec/Package.swift). AGP, Gradle,
compileSdk/targetSdk, and the Facebook Android/iOS SDK pins are already
at their latest stable releases within policy, so no changes there.

Bump plugin version to 0.30.4 (pubspec.yaml, podspec) with matching
CHANGELOG entry.
Copilot AI review requested due to automatic review settings August 2, 2026 19:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Scheduled plumbing upgrade that bumps the plugin patch version and refreshes example app tooling/config to keep the sample project aligned with the plugin’s supported platform/toolchain baseline.

Changes:

  • Bump package version to 0.30.4 (pubspec + podspec) and add a 0.30.4 changelog entry.
  • Update the example Android Kotlin version to 2.4.10.
  • Raise the example iOS app deployment target to iOS 13.0 in the Xcode project.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pubspec.yaml Bumps plugin version to 0.30.4.
ios/facebook_app_events.podspec Keeps CocoaPods spec version in sync with the Dart package version (0.30.4).
CHANGELOG.md Adds release notes for 0.30.4.
example/android/build.gradle Updates ext.kotlin_version to 2.4.10 for the example Android build.
example/android/settings.gradle Updates the Kotlin Android plugin version to 2.4.10 for the example.
example/ios/Runner.xcodeproj/project.pbxproj Raises IPHONEOS_DEPLOYMENT_TARGET from 12.0 to 13.0 across configs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CHANGELOG.md Outdated
@@ -1,3 +1,8 @@
## 0.30.4

- **Update Android toolchain** — Kotlin 2.4.10 (was 2.4.0). AGP, Gradle, and `compileSdk`/`targetSdk` are already at their latest stable releases (8.13.0, 8.13, and 36 respectively), so no change there. The Facebook Android SDK Maven range (`[18.0,19.0)`) already covers the latest 18.x release (18.3.0) and the iOS CocoaPods/SPM `~> 18.0` / `"18.0.0"..<"19.0.0"` pins already cover the latest 18.x release (18.1.0), so no Facebook SDK dependency changes were needed this round.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — reworded in 78beafc to say Gradle stays pinned at 8.13 (matched to AGP 8.13.x) rather than claiming it's "latest stable", since a newer 8.14.x patch exists and was intentionally left out this round.


Generated by Claude Code

Comment thread pubspec.yaml Outdated
description: Flutter plugin for Facebook App Events, an app measurement
solution that provides insight on app usage and user engagement in Facebook Analytics.
version: 0.30.3
version: 0.30.4

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, thanks — updated example/pubspec.lock's facebook_app_events path-dependency version to 0.30.4 in 78beafc.


Generated by Claude Code

DennisAlund and others added 2 commits August 2, 2026 19:11
Regenerate example/pubspec.lock's facebook_app_events path-dependency
pin (0.30.3 -> 0.30.4) to match the version bump, and reword the
CHANGELOG entry so it doesn't claim Gradle is at the "latest stable"
release when a newer 8.14.x patch was intentionally left unpinned.
main released 0.30.4 (tag v0.30.4, commit 3ab9184) while this branch was
open, and this branch had also claimed 0.30.4. Conflict resolved by
keeping both changelog sections and moving this branch's plumbing entry
to a new 0.30.5 heading above the released 0.30.4 one.

The version bump itself was a silent semantic conflict, not a textual
one: both sides wrote the same literal 0.30.4 into pubspec.yaml,
ios/facebook_app_events.podspec and example/pubspec.lock, so git merged
them cleanly onto an already-tagged version. All three are now 0.30.5,
kept in sync per CONTRIBUTING.md's release process.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@DennisAlund
DennisAlund merged commit 9021135 into main Aug 7, 2026
5 checks passed
@DennisAlund
DennisAlund deleted the chore/plumbing-upgrade-2026-08-02 branch August 7, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants