Skip to content

Conversation

@quangnnbb
Copy link

@quangnnbb quangnnbb commented Aug 19, 2025

Description

This PR adds CORS configuration to the vite.config.js files in the basics, minimal, and necessary templates to improve the development experience for Shopify theme development.

Changes

  • Added CORS configuration to templates/basics/vite.config.js
  • Added CORS configuration to templates/minimal/vite.config.js
  • Added CORS configuration to templates/necessary/vite.config.js

Benefits

  • Allows cross-origin requests from Shopify domains (*.myshopify.com, *.shopify.com, admin.shopify.com, *.shopifycdn.com)
  • Enables credentials for authenticated requests
  • Supports common HTTP methods (GET, POST, PUT, DELETE, OPTIONS)
  • Improves development workflow when working with Shopify themes

Testing

  • Verified CORS configuration works with Shopify development environment
  • Tested with multiple template types (basics, minimal, necessary)

Type of Change

  • Enhancement (non-breaking change which adds functionality)

- Add CORS configuration to basics, minimal, and necessary templates
- Allow cross-origin requests from Shopify domains
- Enable credentials and common HTTP methods
- Improve development experience for Shopify theme development
@lukecharle
Copy link

This project is dead and not maintained. You should look to use something like https://shopify-vite.barrelny.com/ instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants