[core:sys/darwin/Foundation] Add bindings for NSPopover and related classes#6311
Open
JacobEvelyn wants to merge 2 commits intoodin-lang:masterfrom
Open
[core:sys/darwin/Foundation] Add bindings for NSPopover and related classes#6311JacobEvelyn wants to merge 2 commits intoodin-lang:masterfrom
JacobEvelyn wants to merge 2 commits intoodin-lang:masterfrom
Conversation
This commit extracts `NSView` bindings from `NSWindow.odin` to a new `NSView.odin` file to better match Odin conventions and give us a better place to add additional `NSView` bindings in the next commit.
53d4985 to
6465f70
Compare
… classes This commit adds bindings for `NSPopover`, as well as related classes used to display the popover and change its content, layout, animation, appearance, etc.
6465f70 to
4be813a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is split into two commits for easier review:
[core:sys/darwin/Foundation] Extract NSView bindings to its own file
This commit extracts
NSViewbindings fromNSWindow.odinto a newNSView.odinfile to better match Odin conventions and give us abetter place to add additional
NSViewbindings in the next commit.[core:sys/darwin/Foundation] Add bindings for NSPopover and related classes
This commit adds bindings for
NSPopover, as well as related classes usedto display the popover and change its content, layout, animation, appearance,
etc.
And here's a "minimal" example that showcases much of the functionality working together: