Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shebang in entrypoint scripts to use /usr/bin/env bash #545

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NamrathShetty
Copy link

No description provided.

@hertell
Copy link

hertell commented Mar 22, 2025

Why do we want this? The entrypoint runs in a a closed pre-defined environment running a Debian based distro, and bash is located in /bin/bash. Feels a bit pointless..

@NamrathShetty
Copy link
Author

all the python files are using /usr/bin/env', thought it would be better if shell scripts follow the same.

@hertell
Copy link

hertell commented Mar 27, 2025

Yes, python, but not bash. Bash exists on basically on all linux distributios in /bin/bash. This docker container is running a debian based distro where bash exist in /bin/bash. This is a closed, pre-defined environment and it's no point to make the script portable. Running the bash script via env has to execute two processes: first env so it can find the location of bash, and then bash itself.. What if env is moved away from /usr/bin to /bin, then we would again have to change the shebang to point where env resides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants