Skip to content

Conversation

@hapat-odoo
Copy link

Created and configured the database for the Real Estate module, defining necessary fields such as property type, tags, buyer, salesperson, and offers. Implemented list, form, and search views with groupings, and added computed fields, inverse functions, and onchange functionalities. Included 'Sold' and 'Cancel' buttons with their corresponding functionality, as well as 'Accept' and 'Refuse' buttons with related logic.

Added a new module for estate property and completed tasks 1, 2, and 3.
 I added a models folder and learned to push data into PostgreSQL using ORM.
Enhanced the Security Logic for improved protection. Added the access control
rights for the estate_property.py file
Introduced a new menu structure for the estate module, including a root menu and submenus for properties. Also added an action for managing estate properties with a corresponding view mode.
-added  search view state field and list and form views

[IMP] estate:  Added list & form view

-added  filter for new or offer received stage

[IMP] estate:  Implemented models and views for property offers

-added  models and views for property offers field
… and types

Implemented models and views for property offers
tags and types
Enhanced property model and views with new fields and improved form layout
 Implemented offer acceptance and refusal actions;
added state management buttons in property views

[FIX] estate: resolve Runbot style and linting errors (Ruff/Semgrep)

This commit fixes all Runbot Check Style issues for the estate module.

[FIX] estate: Cleaned up code by removing unnecessary blank lines in model files
-Refactored validity field to validity_days
-added constraints for price validation
-Implemented inline views and widgets to enhance the user interface within the
Real Estate module.
-Introduced list-ordering functionality to improve the organization and sorting
of listings.
-Added attribute and option configurations to increase customization capabilities
and overall flexibility for users.
-implemented inheritance in models,views
-implemented some ui changes
- Clean whitespace and improve formatting across model files.
- Enhance state management logic in estate_property.
- Remove unused buttons and fields to simplify property views.
- Update selection fields for improved readability and maintainability.
-Enhance property management with offer handling and invoice creation
@robodoo
Copy link

robodoo commented Nov 17, 2025

Pull request status dashboard

-Added Kanban view for properties and updated menu structure
@bit-odoo
Copy link

@hapat-odoo, multiple times i suggested the indentation issue in this PR - #1021
But you are still making the same mistake.
https://runbot.odoo.com/runbot/batch/2246403/build/94084088

…ture

Estate:
- Updated models (property, offer, type) with improved logic and fields
- Fixed offer views and replaced deprecated attrs with modifiers for Odoo 17+
- Updated main property views for better usability
- Added cron XML for scheduled date processing
- Improved manifest metadata

Estate Accounting:
- Added account_move extension for property invoicing
- Updated estate_property accounting bridge
- Added new view estate_move.xml
- Updated access rights
- Cleaned model imports

Awesome Dashboard:
- Updated dashboard JS logic
- Added new SCSS styling
- Improved dashboard XML structure

Awesome Owl:
- Updated manifest and controllers
- Added new components: card, counter, todo_list (JS + XML)
- Updated main.js and playground code
- Added utils.js helper module
@bit-odoo bit-odoo marked this pull request as draft November 25, 2025 10:26
Copy link

@bit-odoo bit-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
I have made some suggestions. You are repeatedly making a basic mistake.

<field name="interval_number">1</field>
<field name="interval_type">days</field>
</record>
</odoo> No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be one empty line at the end of the file.

estate.access_estate_property_offer,access_estate_property_offer,model_estate_property_offer,base.group_user,1,1,1,1
estate.access_estate_property_type,access_estate_property_type,model_estate_property_type,base.group_user,1,1,1,1
estate.access_estate_property_tag,access_estate_property_tag,model_estate_property_tag,base.group_user,1,1,1,1
estate.access_res_users,access_res_users,model_res_users,base.group_user,1,1,1,1 No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be one empty line at the end of the file.

Comment on lines 12 to 24
<button name="action_accept_offer"
string="Accept"
type="object"
icon="fa-check"
title="Accept"
invisible="status"/>

<button name="action_refuse_offer"
string="Refuse"
type="object"
icon="fa-times"
title="Refuse"
invisible="status"/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation issue.

<field name="name">Property Types</field>
<field name="res_model">estate.property.type</field>
<field name="view_mode">list,form</field>
</record>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is good to have one empty line after it.

<field name="name"/>
</list>
</field>
</record>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is good to have one empty line after it.

shape: { id: Number, description: String, isCompleted: Boolean }
}
};
} No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be one empty line at the EOF.

<t t-esc="props.todo.description"/>
</div>
</t>
</templates> No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be one empty line at the EOF.

ev.target.value = "";
}
}
} No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be one empty line at the EOF.

</t>
</div>
</t>
</templates> No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be one empty line at the EOF.

onMounted(() => {
ref.el.focus();
});
} No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be one empty line at the EOF.

…arnings

- Removed deprecated attrs usage in ListView buttons
- Ensured newline at end of XML cron file
- Improved Python validation for property states
- Corrected controller @route type to jsonrpc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants