[ADD] estate: init

[Sylsee]

No description provided.

[robodoo]

[yoba-odoo]

Nice work 👏
Just some small comments, Also if you can squash the LINT and FIX comments with their parent IMP commit it would be better to keep a clean commit history.

[yoba-odoo]

Some more changes 😇

[yoba-odoo]

Almost perfect 👌
Just pay attention to the EOL at the end of every file 😄

[yoba-odoo]

Suggested change

	linked_property = self.env['estate.property'].browse(offer['property_id'])
	linked_property = self.env['estate.property'].browse(offer.get('property_id'))

When fetching something from a dictionary we tend to use get to avoid KeyError if the key doesn't exist. I know mostly the property_id will always be there but it is better safe than sorry 😅

[Sylsee]

Just learn a new python thing ty 😂

[Sylsee]

By doing that I got this error:

I would do that to fix it :

property_id = offer.get('property_id')
if not property_id:
    continue

linked_property = self.env['estate.property'].browse(property_id)

I just think I should raise an error instead of continuing but idk which type of error, I didn't saw any InternalError or something similar in the exceptions definitions. What would you do ?

[yoba-odoo]

Yup, my bad. When using get() and the key doesn't exist it will return None which might cause an Error as browse() is waiting for int

what you can do is fallback on a default value in get() like this:

offer.get('property_id', 0)

[Sylsee]

But then if their is a property with an id of 0 it will not raise an error but change the wrong property no ?

[yoba-odoo]

Normally we don't have a record with id 0, our id sequences are 1-indexed. But to stick with the better-safe-than-sorry ideology we can do something like

if offer.get('property_id'):
    linked_property = self.env['estate.property'].browse(offer['property_id'])