Skip to content

Conversation

@Oussema39
Copy link

No description provided.

@robodoo
Copy link

robodoo commented Dec 15, 2025

Pull request status dashboard

Copy link

@ushyme ushyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work so far. Just a few remarks.

Comment on lines +1 to +3
{
"cSpell.words": ["odoo"]
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{
"cSpell.words": ["odoo"]
}

This file should be removed. Editor-specific settings do not belong in the source code of an Odoo module.

description = fields.Text('Description')
active = fields.Boolean(default=True)
postcode = fields.Char('Postcode')
date_availability = fields.Date('Available From',default=lambda self: fields.Date.today() + timedelta(days=90), copy=False)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
date_availability = fields.Date('Available From',default=lambda self: fields.Date.today() + timedelta(days=90), copy=False)
date_availability = fields.Date('Available From',default=lambda self: fields.Date.context_today(self) + timedelta(days=90), copy=False)

Here, it's better to use fields.Date.context_today() for setting a default to the current date, because it correctly handles the user's timezones.

<field name="view_mode">list,form</field>
</record>

<record id="estate_property_taf_action" model="ir.actions.act_window">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<record id="estate_property_taf_action" model="ir.actions.act_window">
<record id="estate_property_tag_action" model="ir.actions.act_window">

This is just a small typo, but it means that the estate_property_tag_menu_action menu item that references this action is not working

garden = fields.Boolean('Garden')
garden_area = fields.Integer('Garden area')
garden_orientation = fields.Selection(
string='type',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why "type" ?

Comment on lines +67 to +73
<group>
<field name="tag_ids" widget="many2many_tags" />
</group>

<group>
<field name="tag_ids" widget="many2many_tags" />
</group>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why render the tag_ids field twice ?

<search string="Search Properties">
<field name="name" string="Title" />
<field name="postcode" string="Postcode" />
<field name="expected_price" string="Postcode" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="expected_price" string="Postcode" />
<field name="expected_price" string="Expected Price" />

Small copy-paste error.

Comment on lines +79 to +102
<group>
<field name="description" class="mb4" />
</group>
<group>
<field name="bedrooms" class="mb4" />
</group>
<group>
<field name="living_area" class="mb4" />
</group>
<group>
<field name="facades" class="mb4" />
</group>
<group>
<field name="garage" class="mb4" />
</group>
<group>
<field name="garden" class="mb4" />
</group>
<group>
<field name="garden_area" class="mb4" />
</group>
<group>
<field name="garden_orientation" class="mb4" />
</group>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why make a new group for each field ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants