-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[ADD] real_estate: init real estate addon #1065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
Conversation
ushyme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work so far. Just a few remarks.
| { | ||
| "cSpell.words": ["odoo"] | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| { | |
| "cSpell.words": ["odoo"] | |
| } |
This file should be removed. Editor-specific settings do not belong in the source code of an Odoo module.
| description = fields.Text('Description') | ||
| active = fields.Boolean(default=True) | ||
| postcode = fields.Char('Postcode') | ||
| date_availability = fields.Date('Available From',default=lambda self: fields.Date.today() + timedelta(days=90), copy=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| date_availability = fields.Date('Available From',default=lambda self: fields.Date.today() + timedelta(days=90), copy=False) | |
| date_availability = fields.Date('Available From',default=lambda self: fields.Date.context_today(self) + timedelta(days=90), copy=False) |
Here, it's better to use fields.Date.context_today() for setting a default to the current date, because it correctly handles the user's timezones.
| <field name="view_mode">list,form</field> | ||
| </record> | ||
|
|
||
| <record id="estate_property_taf_action" model="ir.actions.act_window"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <record id="estate_property_taf_action" model="ir.actions.act_window"> | |
| <record id="estate_property_tag_action" model="ir.actions.act_window"> |
This is just a small typo, but it means that the estate_property_tag_menu_action menu item that references this action is not working
| garden = fields.Boolean('Garden') | ||
| garden_area = fields.Integer('Garden area') | ||
| garden_orientation = fields.Selection( | ||
| string='type', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why "type" ?
| <group> | ||
| <field name="tag_ids" widget="many2many_tags" /> | ||
| </group> | ||
|
|
||
| <group> | ||
| <field name="tag_ids" widget="many2many_tags" /> | ||
| </group> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why render the tag_ids field twice ?
| <search string="Search Properties"> | ||
| <field name="name" string="Title" /> | ||
| <field name="postcode" string="Postcode" /> | ||
| <field name="expected_price" string="Postcode" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <field name="expected_price" string="Postcode" /> | |
| <field name="expected_price" string="Expected Price" /> |
Small copy-paste error.
| <group> | ||
| <field name="description" class="mb4" /> | ||
| </group> | ||
| <group> | ||
| <field name="bedrooms" class="mb4" /> | ||
| </group> | ||
| <group> | ||
| <field name="living_area" class="mb4" /> | ||
| </group> | ||
| <group> | ||
| <field name="facades" class="mb4" /> | ||
| </group> | ||
| <group> | ||
| <field name="garage" class="mb4" /> | ||
| </group> | ||
| <group> | ||
| <field name="garden" class="mb4" /> | ||
| </group> | ||
| <group> | ||
| <field name="garden_area" class="mb4" /> | ||
| </group> | ||
| <group> | ||
| <field name="garden_orientation" class="mb4" /> | ||
| </group> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why make a new group for each field ?

No description provided.