19.0 app traning raibr #1074
Open
19.0 app traning raibr #1074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hello, can you please ensure that your runbot is green 😄 |
ramezlahzy
force-pushed
the
19.0-app-traning-raibr
branch
from
dc88f8d to
138ea5d
Compare
ramezlahzy
force-pushed
the
19.0-app-traning-raibr
branch
from
138ea5d to
c02245d
Compare
added 3 commits
December 16, 2025 16:05
ramezlahzy
force-pushed
the
19.0-app-traning-raibr
branch
from
b656e0e to
fcbae9f
Compare
Author
Can you check again ;) |
ramezlahzy
requested review from
lost-odoo
and removed request for
lost-odoo
lost-odoo
requested changes
Dec 17, 2025
ramezlahzy
force-pushed
the
19.0-app-traning-raibr
branch
3 times, most recently
from
fd47ba1 to
54edce7
Compare
The models.Constraint syntax does not exist in Odoo's ORM. SQL constraints must be defined using the _sql_constraints class attribute.
ramezlahzy
force-pushed
the
19.0-app-traning-raibr
branch
2 times, most recently
from
ab9d9a6 to
4626609
Compare
The models.Constraint syntax does not exist in Odoo's ORM. SQL constraints must be defined using the _sql_constraints class attribute.
ramezlahzy
force-pushed
the
19.0-app-traning-raibr
branch
from
4626609 to
f073fa7
Compare
lost-odoo
requested changes
Dec 19, 2025
| string="Deadline", | ||
| ) | ||
|
|
||
| # self.property_id.status = 'offer_received' when offer is created |
There was a problem hiding this comment.
This is useless as we can easily understand via the code right below 😄
| _order = 'price desc' | ||
|
|
||
| price = fields.Float(required=True, string="Price") | ||
| _check_price = models.Constraint('Check(price > 0)', "The offer price must be strictly positive.") |
There was a problem hiding this comment.
Try to avoid mixing fields with constraints so it is more readable.
| property_ids = fields.One2many(comodel_name='estate.property', inverse_name='property_type_id', string="Properties") | ||
| offer_count = fields.Integer(compute='_compute_offer_count', string="Offer Count") | ||
|
|
||
| def _compute_offer_count(self): |
There was a problem hiding this comment.
Is it normal that you don't have an api.depends here ?
| <field name="res_model">estate.property.type</field> | ||
| <field name="view_mode">list,form</field> | ||
| </record> | ||
| </odoo> No newline at end of file |
There was a problem hiding this comment.
Please don't forget about the final new line.
| <field name="view_mode">list,form</field> | ||
| <field name="context">{'search_default_filter_available': True}</field> | ||
| </record> | ||
| </odoo> No newline at end of file |
| <field name="domain">[('property_id.property_type_id', '=', active_id)]</field> | ||
| <field name="domain">[('property_id.property_type_id', '=', active_id)]</field> | ||
| </record> | ||
| </odoo> No newline at end of file |
| <field name="res_model">estate.property.offer</field> | ||
| <field name="view_mode">list,form</field> | ||
| <field name="domain">[('property_id.property_type_id', '=', active_id)]</field> | ||
| <field name="domain">[('property_id.property_type_id', '=', active_id)]</field> |
| <field name="status" /> | ||
| <button name="action_accept" type="object" icon="fa-check" title="Accept" /> | ||
| <button name="action_refuse" type="object" icon="fa-times" title="Refuse" /> | ||
|
|
ramezlahzy
force-pushed
the
19.0-app-traning-raibr
branch
from
e97a713 to
8e85311
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.