Mrp product variants#1387
Open
mikelarre wants to merge 9 commits intoodoomrp:8.0from
Open
Conversation
… is selected with the inherited values
…quantity of product
Codecov Report
@@ Coverage Diff @@
## 8.0 #1387 +/- ##
==========================================
+ Coverage 61.73% 61.74% +<.01%
==========================================
Files 284 284
Lines 8561 8563 +2
==========================================
+ Hits 5285 5287 +2
Misses 3276 3276
Continue to review full report at Codecov.
|
oihane
reviewed
Jul 24, 2017
| res = self.product_id_change(product_id, product_qty=product_qty) | ||
| if res['value'].get('product_attribute_ids'): | ||
| del res['value']['product_attribute_ids'] | ||
| if 'product_uom' in res['value']: |
Contributor
There was a problem hiding this comment.
if not res['value'].get('product_uom', True):only delete value if it is False
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[FIX] mrp_product_variants: Solved the problem of uom loss by changing quantity of product